Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use SeedableRandomSampler #2110

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Always use SeedableRandomSampler #2110

merged 8 commits into from
Nov 1, 2023

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Nov 1, 2023

What does this PR do?

Because at the end of the day the trainer will always use a DispatchDataLoader (even in the case of num_gpus == 1), it needs to be able to set the random seed properly for the sampler. The solution is to just always use the SeedableRandomSampler. While our tests (in accelerate)do not fail, they don't account for if the base case is DispatchDataLoader (Trainer tests).

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 1, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it shouldn't hurt.

@muellerzr muellerzr merged commit d8e1285 into main Nov 1, 2023
26 checks passed
@muellerzr muellerzr deleted the seedable-always branch November 1, 2023 17:39
@muellerzr muellerzr mentioned this pull request Nov 1, 2023
5 tasks
muellerzr added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants